Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-12112 Add the value annotations to tyk-stack and component helm charts #291

Merged
merged 10 commits into from
Jun 17, 2024

Conversation

mgnisia
Copy link
Contributor

@mgnisia mgnisia commented May 8, 2024

Description

Add annotations variable to the values.yaml file of all relevant helm charts

Related Issue

Motivation and Context

To support an automated reloading of the gateway or other components of the tyk stack a common approach is to utilize tools like reloader. Currently the helm charts don't support any kind of annotations on the deployment level.

Test Coverage For This Change

I have been templating the helm charts on my machine (helm template) with:

annotations: {}
annotations:
  app: "someAnnotation"

The templating worked without any issues.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mgnisia mgnisia requested a review from a team as a code owner May 8, 2024 13:57
@mgnisia mgnisia requested review from buraksekili and removed request for a team May 8, 2024 13:57
To support an automated reloading of the gateway or other components
of the tyk stack a common approach is to utilize tools like reloader.
Currently the helm charts don't support any kind of annotations
on the deployment level.
@caroltyk caroltyk changed the title Add the value annotations to tyk-stack and component helm charts TT-12112 Add the value annotations to tyk-stack and component helm charts May 10, 2024
@caroltyk
Copy link
Collaborator

Thank you @mgnisia for your contribution. We will review this shortly.

@mgnisia
Copy link
Contributor Author

mgnisia commented May 16, 2024

@caroltyk Hi Carol, could you maybe take another look? that would be awesome.

@caroltyk
Copy link
Collaborator

Hi @mgnisia The PR looks good to me but I'll pass this to the engineers and QA for testing first. Let me update here when it is planned for release.

Copy link
Member

@buraksekili buraksekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @mgnisia for the great contribution! The PR looks great to me!
However, bumping version of the chart triggers release action. Can you please not bump versions of the charts?

@mgnisia
Copy link
Contributor Author

mgnisia commented Jun 6, 2024

Thanks for the update 🙂 will revert the version change beginning of next week 👍🏻

@mgnisia
Copy link
Contributor Author

mgnisia commented Jun 10, 2024

Good morning @buraksekili revert the changes. It would be awesome if you cloud take another look. 👀

Copy link
Member

@buraksekili buraksekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me @mgnisia! thanks for the contribution 🙏 I'll hand over the PR for testing, which will be merged once the testing is finished. I'll let you know if any questions arise during the testing process. once again, thank you for your time and contribution

@bojantyk
Copy link
Contributor

LGTM! @buraksekili we should proceed with merging this PR
Thanks,

@mgnisia
Copy link
Contributor Author

mgnisia commented Jun 17, 2024

@buraksekili can you foresee when this PR will be merged?

@buraksekili buraksekili merged commit 95a321d into TykTechnologies:main Jun 17, 2024
@buraksekili
Copy link
Member

@mgnisia thanks for your contribution 🏅 your contribution is going to be released within the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants